search

ReadAlongs / Studio-Web

Suite of web packages for creating interactive ReadAlongs (this repo was formerly called Web-Component)
https://readalong-studio.mothertongues.org/
Other
9 stars 9 forks source link

fix: bump nx to 18.3.4 so it works on windows again #290

Closed joanise closed 3 months ago

joanise commented 3 months ago

Fixes #289

PR Goal?

Get npx nx cmd package working on Windows again

Fixes?

Fixed #289

Feedback sought?

If you have a Windows machine and had the problem before, test that this fixes it.

Priority?

normal

Tests added?

n/a

How to test?

Run npx nx run-many --targets=serve-test-data,serve --projects=web-component in one shell Run npx nx test:open web-component in another.

On Windows before this PR, the second command would hang and be impossible to abort except by killing the node process. With this PR, testing runs, and Ctrl-C aborts as expected.

Confidence?

high

Version change?

nope

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://ReadAlongs.github.io/Studio-Web/pr-preview/pr-290/ on branch gh-pages at 2024-05-13 21:28 UTC

joanise commented 3 months ago

@dhdaines my PR may be too narrow... Should I keep all these in sync?

$  grep nx package.json
    "@nx/angular": "18.2.4",
    "@nx/eslint": "18.2.4",
    "@nx/eslint-plugin": "18.2.4",
    "@nx/jest": "18.2.4",
    "@nx/storybook": "18.2.4",
    "@nxext/stencil": "^18",
    "nx": "18.3.4",
joanise commented 3 months ago

I'm guessing I should run npx nx migrate 18.3.4 to auto upgrade correctly.