Closed joanise closed 3 months ago
PR Preview Action v1.4.7
:---:
:rocket: Deployed preview to https://ReadAlongs.github.io/Studio-Web/pr-preview/pr-290/
on branch gh-pages
at 2024-05-13 21:28 UTC
@dhdaines my PR may be too narrow... Should I keep all these in sync?
$ grep nx package.json
"@nx/angular": "18.2.4",
"@nx/eslint": "18.2.4",
"@nx/eslint-plugin": "18.2.4",
"@nx/jest": "18.2.4",
"@nx/storybook": "18.2.4",
"@nxext/stencil": "^18",
"nx": "18.3.4",
I'm guessing I should run npx nx migrate 18.3.4
to auto upgrade correctly.
Fixes #289
PR Goal?
Get
npx nx cmd package
working on Windows againFixes?
Fixed #289
Feedback sought?
If you have a Windows machine and had the problem before, test that this fixes it.
Priority?
normal
Tests added?
n/a
How to test?
Run
npx nx run-many --targets=serve-test-data,serve --projects=web-component
in one shell Runnpx nx test:open web-component
in another.On Windows before this PR, the second command would hang and be impossible to abort except by killing the node process. With this PR, testing runs, and Ctrl-C aborts as expected.
Confidence?
high
Version change?
nope