feat: display annotated sentences

ReadAlongs / Studio-Web

Suite of web packages for creating interactive ReadAlongs (this repo was formerly called Web-Component)

https://readalong-studio.mothertongues.org/

Other

9 stars 9 forks source link

feat: display annotated sentences #318

Closed deltork closed 1 month ago

deltork commented 2 months ago

PR Goal?

display manually annotated read-along

Fixes?

Feedback sought?

UI and format check

Priority?

by July 8th

Tests added?

yes

How to test?

spin up web-component npx nx dev web-component and visit http://localhost:8941/ej-fra/index-annotated.html

See test-data/ej-fra/ej-fra-annotated.read long formating

Confidence?

high

Version change?

minor

github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-10 21:12 UTC

joanise commented 2 months ago

This PR is marked as a draft PR, yet you asked for review. Is it ready?

deltork commented 1 month ago

Generally looks good and works well.

One thing: Aidan suggested "removing" instead of just "hiding" the hidden layers, for better rendering, and I agree it would be worth making this change.

I have added that now. Thanks for the reminder!