ReadAlongs / Studio-Web

Suite of web packages for creating interactive ReadAlongs (this repo was formerly called Web-Component)
https://readalong-studio.mothertongues.org/
Other
10 stars 9 forks source link

feat: add navbar navigation #322

Closed roedoejet closed 2 months ago

roedoejet commented 3 months ago

PR Goal?

Add the editor navigation to the main page

Fixes?

Feedback sought?

Priority?

Tests added?

How to test?

Confidence?

Version change?

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-23 21:35 UTC

joanise commented 3 months ago

Various comments:

As for losing state, it happens in both directions: you also lose your Editor state including all edits you've done if you click on Studio. That's gotta be a deal breaker.

deltork commented 3 months ago

I added the fix for the version display to PR for the editor tour

deltork commented 3 months ago

The privacy dialog issue is as far as I can tell is, cause by some code (current don't if it is us or materials doing this) setting the dialog wrapper style to justify-content: flex-start; align-items: center; instead of justify-content: center; align-items: center;