Closed joanise closed 1 month ago
Review changes with SemanticDiff.
Analyzed 4 of 4 files.
Overall, the semantic diff is 11% smaller than the GitHub diff.
Filename | Status | |
---|---|---|
:heavy_check_mark: | packages/studio-web/src/app/app.component.html | 3.57% smaller |
:heavy_check_mark: | packages/studio-web/src/app/shared/download/download.service.ts | 15.7% smaller |
:heavy_check_mark: | packages/studio-web/src/app/editor/editor.component.html | Analyzed |
:heavy_check_mark: | packages/studio-web/src/app/editor/editor.component.ts | Analyzed |
PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-21 14:39 UTC
Looks good!
PR Goal?
Reinsert the code to report Editor events to plausible, thus re-applying #345 to reverted main.
Fixes?
Reports editor events, and download types, to Plausible.
Feedback sought?
sanity checking
Priority?
medium
Tests added?
no
How to test?
on the PR preview, opt in to analytics and see that Editor-related events get reported. Don't forget to opt back out of analytics after!
Confidence?
medium
Version change?
no