search

ReadAlongs / Studio-Web

Suite of web packages for creating interactive ReadAlongs
https://readalong-studio.mothertongues.org/
Other
11 stars 9 forks source link

Dev.del/fix-editor-translations #368

Closed deltork closed 1 week ago

deltork commented 2 weeks ago

PR Goal?

Complete the implementation of the translation management in the editor

Fixes?

Various issues with the translations in the editor

Feedback sought?

Adding/remove/updating translations in the studio and editor. Also finding missing edge cases.

Priority?

HIGH

Tests added?

Will be part of the studio test suites

How to test?

  1. Create a read-along, add some translations.
  2. Export the single file format
  3. Upload it to the editor
  4. Edit the translations
  5. Export the translations

Confidence?

HIGH

Version change?

patch

This patch does not use the agreed upon model we discussed. It just fixes the issues so we can proceed to adding tests before the work to change the modeling is done.

semanticdiff-com[bot] commented 2 weeks ago

Review changes with  SemanticDiff

Changed Files
| File | Status | | :--- | :--- | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#package-lock.json)  [package\-lock\.json](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#package-lock.json) | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#package-lock.json)  72% smaller | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/src/components/read-along-component/read-along.tsx)  [packages/web\-component/src/components/read\-along\-component/read\-along\.tsx](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/src/components/read-along-component/read-along.tsx) | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/src/components/read-along-component/read-along.tsx)  13% smaller | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/studio-web/src/app/shared/download/download.service.ts)  [packages/studio\-web/src/app/shared/download/download\.service\.ts](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/studio-web/src/app/shared/download/download.service.ts) | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/studio-web/src/app/shared/download/download.service.ts)  6% smaller | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/cypress/e2e/edit.cy.js)  [packages/web\-component/cypress/e2e/edit\.cy\.js](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/cypress/e2e/edit.cy.js) | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/cypress/e2e/edit.cy.js)  0% smaller | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/src/utils/utils.ts)  [packages/web\-component/src/utils/utils\.ts](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/src/utils/utils.ts) | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/368/changes#packages/web-component/src/utils/utils.ts)  0% smaller |
github-actions[bot] commented 2 weeks ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-11-08 15:32 UTC

deltork commented 1 week ago

@joanise I have streamlined the translation management as discussed.