ReadAlongs / Studio-Web

Suite of web packages for creating interactive ReadAlongs
https://readalong-studio.mothertongues.org/
Other
11 stars 9 forks source link

build: do not commit browserslist-db updates, it is just noise #372

Open joanise opened 5 days ago

joanise commented 5 days ago

PR Goal?

The strategy I implemented in #348 to always update the browserslist-db on install and commit the results creates a lot of noise: a lot of similar commits, and we still want to update this db in deploy anyway, so it's not the right strategy.

This commit removes the code that commits the changes, and instead updates the db in every workflow that tests or deploys Studio-Web.

Furthermore, Del is going to add has added a build-time dependency that will do this update automatically when you build or serve locally, so we do the same everywhere, automatically, and reasonably quietly.

Fixes?

will reduce the number of silly nearly meaningless commits to package-lock.json.

Feedback sought?

Once Del implements the auto update on build, that will create local changes. Are we OK with just grabbing those with other commits we're doing locally? Or do we want to avoid committing those changes (that would be a real nuisance)?

Priority?

low

Tests added?

n/a

How to test?

It's just CI, so look at CI results for this PR.

Confidence?

medium

Version change?

no

semanticdiff-com[bot] commented 5 days ago

Review changes with  SemanticDiff

Changed Files
| File | Status | | :--- | :--- | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/bundle.yml)  [\.github/workflows/bundle\.yml](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/bundle.yml) | Unsupported file format | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/deploy.yml)  [\.github/workflows/deploy\.yml](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/deploy.yml) | Unsupported file format | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/dev-preview.yml)  [\.github/workflows/dev\-preview\.yml](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/dev-preview.yml) | Unsupported file format | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/end-to-end-tests.yml)  [\.github/workflows/end\-to\-end\-tests\.yml](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/end-to-end-tests.yml) | Unsupported file format | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/pr-preview.yml)  [\.github/workflows/pr\-preview\.yml](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/pr-preview.yml) | Unsupported file format | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/release.yml)  [\.github/workflows/release\.yml](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/release.yml) | Unsupported file format | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/windows-tests.yml)  [\.github/workflows/windows\-tests\.yml](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#.github/workflows/windows-tests.yml) | Unsupported file format | | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#packages/studio-web/project.json)  [packages/studio\-web/project\.json](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#packages/studio-web/project.json) | [](https://app.semanticdiff.com/gh/ReadAlongs/Studio-Web/pull/372/changes#packages/studio-web/project.json)  0% smaller |
github-actions[bot] commented 5 days ago

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://ReadAlongs.github.io/Studio-Web/pr-preview/pr-372/ on branch gh-pages at 2024-11-20 14:25 UTC