Adding meta tag to .readalong

deltork commented 4 months ago

PR Goal?

To add meta data to read along file format

Fixes?

enhancement of format

Feedback sought?

meta data with generator information is being added to .readalong files

Priority?

Normal

Tests added?

Modified existing test with meta data

How to test?

cd test; readalongs align -l fra data/ej-fra.txt data/ej-fra.wav meta_test

Confidence?

High

Version change?

Minor

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.26%. Comparing base (a5f5368) to head (b1cc821). Report is 6 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #225 +/- ## ========================================== + Coverage 87.23% 87.26% +0.02% ========================================== Files 21 21 Lines 1770 1774 +4 Branches 321 321 ========================================== + Hits 1544 1548 +4 Misses 189 189 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

roedoejet commented 4 months ago

@deltork - it looks like this PR isn't rebased on top of main, it seems to contain a lot of duplicate commits. Is b1cc821 the only new commit?

If so, I recommend rebasing or simply cherry-picking that commit on a new branch. I've done that here. Steps to reproduce:

git checkout main
git pull
git branch dev.ap/versioning-patch
git cherry-pick b1cc821
git push origin dev.ap/versioning-patch

ReadAlongs / Studio