Closed joanise closed 4 months ago
Doh, I only fixed some tests. Turning this back into a draft for the moment.
OK, fixed, tests should pass now, this PR is ready to review.
Attention: Patch coverage is 87.50000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 87.21%. Comparing base (
29ec752
) to head (823a2b7
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
readalongs/align.py | 81.81% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Improvements pushed, this should be ready to re-review now. Thanks for the review!
PR Goal?
As agreed Wednesday, structure the
readalongs align
output like the web app's Web Bundle, withwww
andOffline-HTML
subfolders.Feedback sought?
run align with
-o html
and confirm you like the resultsPriority?
normal
Tests added?
updated existing tests
How to test?
run
readalongs align
with various output options.Confidence?
medium-high
Version change?