ReadAlongs / Studio

Audiobook alignment for Indigenous languages
https://readalongs.github.io/Studio/
Other
38 stars 20 forks source link

feat: structure align output into www and Offline-HTML dirs #231

Closed joanise closed 4 months ago

joanise commented 4 months ago

PR Goal?

As agreed Wednesday, structure the readalongs align output like the web app's Web Bundle, with www and Offline-HTML subfolders.

Feedback sought?

run align with -o html and confirm you like the results

Priority?

normal

Tests added?

updated existing tests

How to test?

run readalongs align with various output options.

Confidence?

medium-high

Version change?

joanise commented 4 months ago

Doh, I only fixed some tests. Turning this back into a draft for the moment.

joanise commented 4 months ago

OK, fixed, tests should pass now, this PR is ready to review.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.21%. Comparing base (29ec752) to head (823a2b7). Report is 1 commits behind head on main.

Files Patch % Lines
readalongs/align.py 81.81% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #231 +/- ## ========================================== - Coverage 87.24% 87.21% -0.04% ========================================== Files 21 21 Lines 1772 1783 +11 Branches 321 323 +2 ========================================== + Hits 1546 1555 +9 Misses 189 189 - Partials 37 39 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joanise commented 4 months ago

Improvements pushed, this should be ready to re-review now. Thanks for the review!