search

ReadAlongs / Studio

Audiobook alignment for Indigenous languages
https://readalongs.github.io/Studio/
Other
38 stars 20 forks source link

Feature: Updated DTD to support annotations #236

Closed deltork closed 2 months ago

deltork commented 3 months ago

PR Goal?

The goal of the PR is to provide support for annotation layers in the read along. If a .readalong has annotation layers, it should be acceptable to the CLI

Fixes?

n/a

Feedback sought?

sanity check

Priority?

high

Tests added?

yes

How to test?

cd test/data; readalongs align -o html -f -l fra ej-fra-annotated.readalong ej-fra.m4a ej-fra-annotated

Confidence?

High

Version change?

n/a

required for https://github.com/ReadAlongs/Studio-Web/pull/330

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.21%. Comparing base (6087b74) to head (a559040). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #236 +/- ## ========================================== - Coverage 87.60% 87.21% -0.40% ========================================== Files 21 21 Lines 1783 1783 Branches 323 323 ========================================== - Hits 1562 1555 -7 - Misses 183 189 +6 - Partials 38 39 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

deltork commented 3 months ago

This seems good! Except, should we increment the version number on the DTD?

I will bump up the format version to 1.2

joanise commented 2 months ago

I'm guessing CI fails here due (at least in part) to the panphon issue. Releasing g2p 2.1.0 or restricting panphon<0.21 might be needed temporarily.

joanise commented 2 months ago

I fixed CI now. There were two problems, in the end: