ReadieFur / BSDataPuller

Gathers data about the current map you are playing to then be sent out over a websocket for other software to use, e.g. A web overlay like BSDP-Overlay. This mod works with multi PC setups!
https://github.com/ReadieFur/BeatSaber-Overlay
GNU General Public License v3.0
39 stars 10 forks source link

[Suggestion] Note spawning, cut and miss events? #20

Closed Protected closed 2 years ago

Protected commented 2 years ago

I'd like to update the Note History overlay from HTTP Status for 1.18 to use DataPuller for 1.22+ .

ReadieFur commented 2 years ago

What does that do exactly? If it sends out data of the previously cut notes, I decided to not add that to live data as it would then be sending too much data. What I could do is store that in the map data that only gets sent periodically.

Protected commented 2 years ago

It would independently deliver information for each note when it's spawned, cut, or missed (including bombs). That's 2 events per note, one at the moment of spawning and one at the moment of cutting or missing.

You can do this with just two events per note: https://www.twitch.tv/videos/1486707220?t=00h17m38s

I would deliver these separately from other live updates, of course. You could even make them optional - just add a toggle to turn them on when they are wanted (with the tradeoff that you need a good enough CPU, I guess).

This is how the data was structured in BeatSaberHTTPStatus (which is no longer to be updated): https://github.com/opl-/beatsaber-http-status/blob/master/protocol.md#note-cut-object

I understand the old noteFullyCut event no longer makes sense in 1.20+ scoring, but that's fine - it's not important.