search

ReadieFur / BSDataPuller

Gathers data about the current map you are playing to then be sent out over a websocket for other software to use, e.g. A web overlay like BSDP-Overlay. This mod works with multi PC setups!
https://github.com/ReadieFur/BeatSaber-Overlay
GNU General Public License v3.0
39 stars 10 forks source link

Fix Combo, Misses, and NotesSpawned #27

Open ChrisJAllan opened 2 years ago

ChrisJAllan commented 2 years ago

Fixes #26

While testing, I noticed bad cuts weren't breaking combo, adding misses, or adding notes spawned, so fixed those. Bomb hits are not counted under misses, which is consistent with the documentation and other mods, but the LiveData.ColorType is now set correctly before returning.

Side note: my compiler really doesn't like DefaultValueTAttribute because CS0698? How do you get around this? I did the annoying thing and made each use it's own class, but that's a pain. Found it, C# 11 preview feature

UnskilledFreak commented 1 year ago

Can confirm the issues in #26, as well as full combo does not set to false when a bad cut happend. Also misses are not incremented when that happend. I did not yet tested this fix here but code looks ok to me.