ReadieFur / BSDataPuller

Gathers data about the current map you are playing to then be sent out over a websocket for other software to use, e.g. A web overlay like BSDP-Overlay. This mod works with multi PC setups!
https://github.com/ReadieFur/BeatSaber-Overlay
GNU General Public License v3.0
39 stars 10 forks source link

Critical error OnApp reload #9

Closed ReadieFur closed 3 years ago

ReadieFur commented 3 years ago

I have had messages say that my mod was causing critical erorrs when the app was reloaded, e.g. a setting in the settings menu was changed. This would cause the ScoreController and GameEnergyController to stop working entirely.

ReadieFur commented 3 years ago

The websocket server is set to start up when the zenject OnApp is run. On this OnApp event I have an IInitializable and IDisposable websocket class. On dispose I tell the websocketserver to stop but it seems that this kills the game which confuses me but im trying to figure out why.

ReadieFur commented 3 years ago

I have fixed the issue by moving it outsize of zenject however I am still trying to figure out why this broke so badly. (These messages were snippits from a Discord DM I had).