search

Readify / GitViz

Real-time, presentation-quality, Git visualizer to help with Git training
305 stars 86 forks source link

Some improvements... #4

Closed pmiossec closed 9 years ago

pmiossec commented 9 years ago

(each commit is an improvement)

pmiossec commented 9 years ago

@rbanks54 and @tathamoddie up!!

rbanks54 commented 9 years ago

Thanks for the PR :-). Sorry for the delay in getting back to you though :-(

The .editorconfig is a great idea! Thanks for that! It would be easier to accept if it was in a separate PR though.

The auto resizing of the window doesn't work very well. Every time you change branches, or switch to a different repository, things get moved all over the place and the window position changes. It's visually jarring. Much more so than the graph redraw issue we currently have.

It also breaks expected UI behaviours. For example, if I resize the window manually, then do an action that causes the graph to redraw, the auto-resize overwrites my window sizing.

Instead of doing an auto-resize, could you add a button to manually trigger a resize instead? Maybe toward the top right of the window?

The new HEAD positioning is a nice change. Thanks!

Command line argument? Ditto :+1: Also a good change.

pmiossec commented 9 years ago

@rbanks54 I have removed the window resizing and will try to do something that suite you AND me. Because I don't like when I open a repository that the window stay tiny and that we can't see the whole tree (for a small repository). Perhaps just add a button like you say AND automatically change the size of the windows the first time the tree is loaded...

I have done the fix on the height of the button.

I will do a separate PR for the .editorconfig so that's ready to merge ;)

rbanks54 commented 9 years ago

@pmiossec The other PR is merged. Thanks! For the resizing, an initial resize when the repo is first loaded should be fine. If you can avoid moving the top/left coordinates of the window when you resize that would be good too.

pmiossec commented 9 years ago

You could also merge this one, I will do another pull request for the window resize later...