search

Readify / TeamFlash

Build light driver for TeamCity + Delcom 904003 USB light
https://tc.readifycloud.com/viewLog.html?buildTypeId=bt10&buildId=lastSuccessful&tab=artifacts&guest=1
17 stars 16 forks source link

Conversation Starter #12

Closed BenPhegan closed 10 years ago

BenPhegan commented 11 years ago

Hi,

Started having a play with the original codebase quite a while back, and it looks pretty different now. Basically it has gotten to the point that it might be worth either folding it back in, or forking it for good as just too different to merge back in, so I thought I would touch base via a pull request to see which way you want to go.

Major differences between current and this fork:

  1. Included support for Philips Hue lights. Basically this means you can spin up either a Delcom or the Philips Hue with the same codebase. Easily extendable to more types of "lights" as well.
  2. Using .Net 4.5. This is more for convenience, as it was the first Hue API that I found on NuGet, so could pull it out if this was a concern. Not really using any async/await/.Net4.5 stuff otherwise.
  3. Probably not Mono compatible anymore (no specific testing)
  4. Currently haven't put the "investigations" code back in
  5. Runs many build checks in parallel, with an event-based triggering of light changes. This was due to scale, as we sometimes wanted to check a few hundred builds and it just wasn't cutting it one at a time
  6. Event based triggering allows for a "flash" of colour to represent the status of each individual build. Kinda lets you know that it is working and give you a clue as to the number of red/green/amber/blue etc (this does not function on the Hue code as it responds far too slowly to support the checks...and it would probably be headache-inducing).
  7. Probably a bunch of other things besides.

If you are interested to pull this back in, happy to clean it up, refactor for feature parity, document etc etc. Consider this more a conversation starter rather than a pull request with expectations of making it in as is.

Anyway, let me know your thoughts.

Regards,

Ben Phegan

BenPhegan commented 10 years ago

Point taken. Will fork it. :)