search

Reading-eScience-Centre / edal-java

Environmental Data Abstraction Layer libraries
Other
39 stars 30 forks source link

Is it possible for CdmGridDatasetFactory to be subclassable again? #103

Closed lesserwhirls closed 6 years ago

lesserwhirls commented 6 years ago

Last year, @guygriffiths madeCdmGridDatasetFactory subclassable be removing the final declaration (see here). In the TDS, we subclass it to handle NcML aggregations. If it's not possible to make CdmGridDatasetFactory subclassable, might you suggest another way to go? Thanks!

guygriffiths commented 6 years ago

Not sure why that got reverted, I've just done that in the develop branch.

lesserwhirls commented 6 years ago

Thanks @guygriffiths!