Parameter vs Variable IDs

Reading-eScience-Centre / edal-java

Environmental Data Abstraction Layer libraries

Other

39 stars 30 forks source link

Parameter vs Variable IDs #23

Closed letmaik closed 7 years ago

letmaik commented 9 years ago

The edal.feature.Feature interface refers to parameter IDs. However a Parameter only has a getVariableId method and currently there is no such thing as a parameter ID left (anymore).

I would remove getParameterIds from Feature, since this information is easy to get from getParameterMap. Then you would be left with getParameter(String variableId) and a different description for getParameterMap.

guygriffiths commented 7 years ago

I've done this, although rather than removing getParameterIds entirely (since it's quite widely used as a convenience method), I've renamed it getVariableIds, which is more accurate