Reading-eScience-Centre / edal-java

Environmental Data Abstraction Layer libraries
Other
39 stars 30 forks source link

feature(section): Add support for extent in vertical section #67

Closed jripault closed 8 years ago

jripault commented 8 years ago

Add parameter SECTION-ELEVATION which takes an interval like 0/70 When present, the vertical section chart will be based on the depth extent given. The colormap will also be constructed with the extent. Some methods have been added to extract data.

Here is a sample : image

guygriffiths commented 8 years ago

Thanks for the change. I've merged it and will check it all works fine before the next release, which I plan to do soon. Just a quick point - if you change method signatures (createVerticalSectionChart in this case), could you also update the Javadoc? It's not a big deal and I'm happy to do it, but I don't always notice/remember.

jripault commented 8 years ago

Thx, sorry for the Javadoc. I won't miss it next time ;)