search

Reading-eScience-Centre / pycovjson

Create CovJSON files from common scientific data formats
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

ISSUE-42 unable to decode time units ... with the default calendar #43

Closed lewismc closed 6 years ago

lewismc commented 6 years ago

This issue addresses #42 however in doing so we lessens the strictness of the conversion... In the meantime, I've actually reported the issue with the input product over at PO.DAAC.

RileyWilliams commented 6 years ago

Hi @lewismc, maybe this should be an option which can be set using a command line flag?

lewismc commented 6 years ago

Hi @RileyWilliams I was also thinking we could implement a try catch scenario where the strict attempt (decode_times=True) is made first with an Exception being caught, handled and the reason being printed to standard out, then the less strict attempt (decode_times=False) being attempted. Does this sound better?

RileyWilliams commented 6 years ago

@lewismc, yeah sounds good, as long as we are warning the user I think it's okay.

RileyWilliams commented 6 years ago

@lewismc, merged now, sorry it took so long!