search

Reading-eScience-Centre / pycovjson

Create CovJSON files from common scientific data formats
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

Domainype needs to be inferred #44

Open RiverHendriksen opened 6 years ago

RiverHendriksen commented 6 years ago

Currently the domainType is hard coded as 'Grid' in line 84 of write.py, however it should be inferred from the data that is given as input.

RileyWilliams commented 6 years ago

Hello @RiverHendriksen, this is probably something which will have to be user specified. The different domain types are specified here. But currently I believe the tool only supports the 'Grid' type, so more changes will be necessary to support the other types.

lewismc commented 6 years ago

@RileyWilliams do you have any suggestion as to how one may be able to infer this directly from the input product?

RileyWilliams commented 6 years ago

Hi @lewismc, I cant think of any way of doing this accurately without having as a user flag, but perhaps the coordinate systems used by the input file could be used to make an educated guess.

lewismc commented 6 years ago

Same... a flag would be a good start. @RiverHendriksen can you look into implementing the CLI flag please?