search

ReadyTalk / avian

[INACTIVE] Avian is a lightweight virtual machine and class library designed to provide a useful subset of Java's features, suitable for building self-contained applications.
https://readytalk.github.io/avian/
Other
1.22k stars 173 forks source link

Fix delete windows #413

Closed brandonecraig closed 9 years ago

brandonecraig commented 9 years ago

Fixing java.io.File.delete() for windows.

Adding gradle so the build system is comparable to master.

joshuawarner32 commented 9 years ago

@brandonecraig - can you make a PR to master with just the change in question? We can let travis verify it there, and then we can tackle backporting it and setting up a release branch, as necessary.

Nit: I really don't like the preprocessor stuff and C++ expressions breaking out of a strict tree structure; I think it hurts readability. I'd much rather see the REMOVE like duplicated.

Another, smaller nit: I'd prefer using GetFileAttributes instead of PathIsDirectory, so we don't have to link in extra windows libs.