search

ReadyTalk / avian

[INACTIVE] Avian is a lightweight virtual machine and class library designed to provide a useful subset of Java's features, suitable for building self-contained applications.
https://readytalk.github.io/avian/
Other
1.22k stars 173 forks source link

ensure ci.sh exits with error when any test fails #426

Closed dicej closed 9 years ago

dicej commented 9 years ago

As explained in http://stackoverflow.com/questions/25794905/why-does-set-e-true-false-true-not-exit, "set -e" will only cause the script to exit if the failing command is "unhandled". The fancy || and && shortcuts we were using to run some of the tests caused bash to think we were handling the errors, which isn't what we wanted.

Fixes #416

joshuawarner32 commented 9 years ago

I'd hazard a guess to say that the first and third hunks aren't strictly necessary. However, do show a good example, and having that precedent in there ought to discourage further similar mistakes.

FWIW, I wasn't seeing this locally because I wasn't actually making ci.sh fail how it was in #425.

Good find!

joshuawarner32 commented 9 years ago

Checking the build output this time... And looks good!