search

ReadyTalk / avian

[INACTIVE] Avian is a lightweight virtual machine and class library designed to provide a useful subset of Java's features, suitable for building self-contained applications.
https://readytalk.github.io/avian/
Other
1.22k stars 173 forks source link

- fixed building for iOS 9 #464

Closed benstadin closed 9 years ago

benstadin commented 9 years ago
benstadin commented 9 years ago

I figured I didn't remove the default copyright notices that Xcode creates for each source file. Shall I remove them?

dicej commented 9 years ago

Hi Ben,

Thanks for doing this and updating the hello-ios project. I assume you meant to ask the copyright notice question on the hello-ios PR rather than this one. Anyway, yes, we should probably remove those so they don't cause confusion.

I suppose we should really replace them with an appropriate license notice, but I never took the time to do that with the original code, so just removing them entirely is fine for now. The intention is that it's public domain example code.

benstadin commented 9 years ago

Hi Joel,

I've removed the copyright notes and edited the pull request. I explicitly mention in the commit message that the code is public domain.

Von: Joel Dice notifications@github.com<mailto:notifications@github.com> Antworten an: ReadyTalk/avian reply@reply.github.com<mailto:reply@reply.github.com> Datum: Montag, 2. November 2015 00:41 An: ReadyTalk/avian avian@noreply.github.com<mailto:avian@noreply.github.com> Cc: Benjamin Stadin benjamin.stadin@heidelberg-mobil.com<mailto:benjamin.stadin@heidelberg-mobil.com> Betreff: Re: [avian] - fixed building for iOS 9 (#464)

Hi Ben,

Thanks for doing this and updating the hello-ios project. I assume you meant to ask the copyright notice question on the hello-ios PR rather than this one. Anyway, yes, we should probably remove those so they don't cause confusion.

I suppose we should really replace them with an appropriate license notice, but I never took the time to do that with the original code, so just removing them entirely is fine for now. The intention is that it's public domain example code.

Reply to this email directly or view it on GitHubhttps://github.com/ReadyTalk/avian/pull/464#issuecomment-152877619.

dicej commented 9 years ago

Thanks. I'm updating my Xcode now so I can test this myself. On Nov 1, 2015 5:26 PM, "benstadin" notifications@github.com wrote:

Hi Joel,

I've removed the copyright notes and edited the pull request. I explicitly mention in the commit message that the code is public domain.

Von: Joel Dice notifications@github.com<mailto:notifications@github.com> Antworten an: ReadyTalk/avian <reply@reply.github.com<mailto: reply@reply.github.com>> Datum: Montag, 2. November 2015 00:41 An: ReadyTalk/avian <avian@noreply.github.com<mailto: avian@noreply.github.com>> Cc: Benjamin Stadin <benjamin.stadin@heidelberg-mobil.com<mailto: benjamin.stadin@heidelberg-mobil.com>> Betreff: Re: [avian] - fixed building for iOS 9 (#464)

Hi Ben,

Thanks for doing this and updating the hello-ios project. I assume you meant to ask the copyright notice question on the hello-ios PR rather than this one. Anyway, yes, we should probably remove those so they don't cause confusion.

I suppose we should really replace them with an appropriate license notice, but I never took the time to do that with the original code, so just removing them entirely is fine for now. The intention is that it's public domain example code.

Reply to this email directly or view it on GitHub< https://github.com/ReadyTalk/avian/pull/464#issuecomment-152877619>.

— Reply to this email directly or view it on GitHub https://github.com/ReadyTalk/avian/pull/464#issuecomment-152881200.