avian fails to build with java 10.0.1 due to java version parsing

[ianatha]

Using the latest Oracle Java 10.0.1 JDK, on a Mac, make fails due to some assumptions regarding version strings.

• Java version:

  java version "10.0.1" 2018-04-17
  Java(TM) SE Runtime Environment 18.3 (build 10.0.1+10)
  Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.1+10, mixed mode)

• Avian repo:

  cd2df9e0e3ff7b9c63ade10f74098e5b658eabb4

• make output:

  compiling build/macosx-x86_64/tools/type-generator/main-build.o
  compiling build/macosx-x86_64/system/posix-build.o
  compiling build/macosx-x86_64/system/posix/crash-build.o
  compiling build/macosx-x86_64/system/posix/memory-build.o
  compiling build/macosx-x86_64/system/posix/signal-build.o
  compiling build/macosx-x86_64/finder-build.o
  compiling build/macosx-x86_64/util/arg-parser-build.o
  linking build/macosx-x86_64/generator
  compiling classpath classes
  javac: invalid source release: 1.
  Usage: javac <options> <source files>
  use --help for a list of possible options
  make: *** [build/macosx-x86_64/classpath.dep] Error 2

[ianatha]

Quick and ugly workaround:

diff --git a/makefile b/makefile
index 7a68bccb..f40249dc 100755
--- a/makefile
+++ b/makefile
@@ -8,7 +8,7 @@ get-java-version = $(shell "$1" -version 2>&1 \
                | sed -e 's/.*version "1.\([^.]*\).*/\1/' \
                                        -e 's/.*version "9.*/9/')

-java-version := $(call get-java-version,$(JAVA_HOME)/bin/java)
+java-version := "8"

 build-arch := $(shell uname -m \
        | sed 's/^i.86$$/i386/' \
@@ -1811,7 +1811,7 @@ $(generated-code): %.cpp: $(src)/types.def $(generator) $(classpath-dep)
 $(classpath-dep): $(classpath-sources) $(classpath-jar-dep)
        @echo "compiling classpath classes"
        @mkdir -p $(classpath-build)
-       $(javac) -source 1.$(java-version) -target 1.$(java-version) \
+       $(javac) -source $(java-version) -target $(java-version) \
                -d $(classpath-build) -bootclasspath $(boot-classpath) \
                $(classpath-sources)
        @touch $(@)
@@ -1887,10 +1887,10 @@ $(test-dep): $(test-sources) $(test-library)
        @mkdir -p $(test-build)
        files="$(shell $(MAKE) -s --no-print-directory build=$(build) $(test-classes))"; \
        if test -n "$${files}"; then \
-               $(javac) -source 1.$(java-version) -target 1.$(java-version) \
+               $(javac) -source $(java-version) -target $(java-version) \
                        -classpath $(test-build) -d $(test-build) -bootclasspath $(boot-classpath) $${files}; \
        fi
-       $(javac) -source 1.2 -target 1.1 -XDjsrlimit=0 -d $(test-build) \
+       $(javac) -source 1.6 -target 1.6 -XDjsrlimit=0 -d $(test-build) \
                -bootclasspath $(boot-classpath) test/Subroutine.java
        @touch $(@)

@@ -1899,7 +1899,7 @@ $(test-extra-dep): $(test-extra-sources)
        @mkdir -p $(test-build)
        files="$(shell $(MAKE) -s --no-print-directory build=$(build) $(test-extra-classes))"; \
        if test -n "$${files}"; then \
-               $(javac) -source 1.$(java-version) -target 1.$(java-version) \
+               $(javac) -source $(java-version) -target $(java-version) \
                        -d $(test-build) -bootclasspath $(boot-classpath) $${files}; \
        fi
        @touch $(@)

[ianatha]

closing abandoned issue :(