Real-Dev-Squad / discord-slash-commands

MIT License
4 stars 21 forks source link

Feat : Updated mention each flow #205

Closed joyguptaa closed 3 months ago

joyguptaa commented 4 months ago

Date: 8 March 2024

Developer Name: Joy Gupta


Issue Ticket Number

Description

This PR contains updated mention-each functionality. And also updated a field in some of the existing test cases.

Documentation Updated?

Under Feature Flag

Database Changes

Breaking Changes

Development Tested?

Note

In the images/video below you will see that is says found 3 users but then end up tagging so many users. This is because I am multiplying the matched users to test it out.

Screenshots

The numbers before each message are just for showing purpose. I've removed that in the PR.

For failing use case

https://github.com/Real-Dev-Squad/discord-slash-commands/assets/56365512/18939c54-f72b-45a5-8fc6-30d95ad4f7bf

Video playback speed is 2x

https://github.com/Real-Dev-Squad/discord-slash-commands/assets/56365512/a45b3c2b-8bc1-46b6-aecd-31253e9add81

Tested it for 300 Users

Screenshot 2024-03-09 at 11 41 38 AM

Test Coverage

### For guild.ts Screenshot 2024-03-08 at 1 10 08 AM Screenshot 2024-03-08 at 1 11 30 AM
### For mentionEach.ts Screenshot 2024-03-09 at 5 09 33 PM Screenshot 2024-03-09 at 5 04 43 PM