search

Real-Dev-Squad / members-site

https://members-app-v2.vercel.app
MIT License
4 stars 22 forks source link

fix: place footer to bottom when no full screen content present #149

Closed ssxdev closed 3 months ago

ssxdev commented 3 months ago

Date: 31-07-2024

Developer Name: Surendar Singh

Issue Ticket Number

148

Description

Documentation Updated?

Under Feature Flag

Database Changes

Breaking Changes

Development Tested?

Screenshots

Screenshot 1 ![image](https://github.com/user-attachments/assets/32b05892-6cc7-4cb3-b936-1104c037062d) ![image](https://github.com/user-attachments/assets/572b5619-6d2e-4d9c-a7d8-04c0cf2261bc) ![image](https://github.com/user-attachments/assets/c86505fd-65c5-4fcc-8526-7b38f4ac4528) ![image](https://github.com/user-attachments/assets/ef837b52-ed0c-4675-bfa0-db0afe397872)

Test Coverage

Screenshot 1 This fail tests are not related to the UI changes that I made. ![image](https://github.com/user-attachments/assets/7d3389a5-b969-44c1-8155-0edd08785908)

Additional Notes

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
members-app-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 9:15pm
ssxdev commented 3 months ago

LGTM, but are these test cases failing for this branch only? which you have mentioned in the PR description

@tejaskh3 I forked the "develop" branch, which fails the same test cases

vinit717 commented 3 months ago

image Here some misalignment there can you please check this out

ssxdev commented 3 months ago

Here some misalignment there can you please check this out

There is a gap because "Real Dev Squad Members" and "New User" are separate components that should have a list of members inside them. Both components are separated by some gap because both are separate categories. And also these changes are outside the scope of this particular task PR. TBH a complete revamp is required for this repo.

image