Real-Dev-Squad / members-site

https://members-app-v2.vercel.app

MIT License

4 stars 23 forks source link

fix: removed navbar sticky position #173

Closed AtulHande03a closed 2 weeks ago

AtulHande03a commented 2 weeks ago

Date: 12/09/2024

Developer Name: Atul Hande

Issue Ticket Number

583 (as per old website-member repo)

Description

The dropdown menu scrolled along with the page at full-screen width
while navbar remain fixed
In other tabs navbar gets scrolled along with the dropdown menu
Issue was navbar having position : sticky
while the dropdown scroll movement is correct as per other tabs
removed navbar sticky property and made it scroll, to resemble it as other tabs

Documentation Updated?

[ ] Yes
[x] No

Under Feature Flag

[ ] Yes
[x] No

Database Changes

[ ] Yes
[x] No

Breaking Changes

[ ] Yes
[x] No

Development Tested?

[x] Yes
[ ] No

Screenshots

Image Before Changes

![image-before](https://github.com/user-attachments/assets/e7cf3601-3fcf-494b-9115-b385265276b4)

As in the picture, navbar remains fixed while dropdown menu scrolls up while scrolling page up.

Test Coverage

Image after changes were implemented

![image-after](https://github.com/user-attachments/assets/9f304319-4bcb-4d40-9209-2394893f0760)

Checked for any UI issues occurring when this change is made. Checked for various screen width sizes to find an error.

Additional Notes

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
members-app-v1	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 7:34pm