Real-Dev-Squad / members-site

https://members-app-v2.vercel.app
MIT License
4 stars 22 forks source link

Improvement: new card UI for member #91

Closed anishpawaskar closed 1 year ago

anishpawaskar commented 1 year ago

Issue: https://github.com/Real-Dev-Squad/members-site/issues/55

What is change?

Before : - feat_ worked on member improvements by vvaibhavdesai · Pull Request #64 · Real-Dev-Squad_members-site - Google Chrome 29-08-2023 00_18_57

After :-

https://github.com/Real-Dev-Squad/members-site/assets/22213872/2cfc4c30-f0ae-4fe4-894c-218fdc3bbba3

Written test for MembersCardPresentation component

MembersCardPresentation test tsx - members-site - Visual Studio Code 30-08-2023 02_40_49 (2)

anishpawaskar commented 1 year ago

As seen in the video recording, the hovering over image effect doesn't look good to me...can you tell me the reason why was this effect done over the image, in my opinion, it is not required.

As we wanted to make new card UI similar to this https://codepen.io/veronicadev/pen/WJyOwG that's why i'm using hover effect only on image and scaling up the card size by 1.1 on both axis

Pratiyushkumar commented 1 year ago

As seen in the video recording, the hovering over image effect doesn't look good to me...can you tell me the reason why was this effect done over the image, in my opinion, it is not required.

As we wanted to make new card UI similar to this https://codepen.io/veronicadev/pen/WJyOwG that's why i'm using hover effect only on image and scaling up the card size by 1.1 on both axis

I am not sure if we require this design to be implemented because I don't find the use case here for this design as it is making the card here look bad according to me. can you please get approval of Ankush for this design?

anishpawaskar commented 1 year ago

As seen in the video recording, the hovering over image effect doesn't look good to me...can you tell me the reason why was this effect done over the image, in my opinion, it is not required.

As we wanted to make new card UI similar to this https://codepen.io/veronicadev/pen/WJyOwG that's why i'm using hover effect only on image and scaling up the card size by 1.1 on both axis

I am not sure if we require this design to be implemented because I don't find the use case here for this design as it is making the card here look bad according to me. can you please get approval of Ankush for this design?

sure👍