[RFC] Stop tests on push

Real-Dev-Squad / mobile-app

The main app for our organization

MIT License

12 stars 30 forks source link

[RFC] Stop tests on push #137

Open RitikJaiswal75 opened 2 years ago

RitikJaiswal75 commented 2 years ago

Issue

When a PR is created, the git workflow runs tests on all the pull requests, but once the tests are run on pull requests they run again during push

When was the issue discovered?

The issue was discovered on 18th August 2022 during a hangout call while trying to merge PRs.

Files that might be creating this

.github/workflows/test.yml

Screenshot of the Problem

pranikz commented 1 year ago

I can pick this issue . ETA: 2nd October

shreya-mishra commented 1 year ago

Will you please mention the ETA too ?

pranikz commented 1 year ago

Hello @RitikJaiswal75 I have explored in the repo and found out the CI/ CD operations are happening here on PRs not on push and afaik the issue was It was running on Push too , seems the problem is solved in the case of mobile-app repo, If it is happening here can you just point out where it is happening on push?

CC : @shreya-mishra

RitikJaiswal75 commented 1 year ago

it is still present in codeql.yml

RitikJaiswal75 commented 1 year ago

CodeQl YML runs both on push and pull. Is it necessary and if yes why?