Real-Dev-Squad / website-backend

The backend code for all our website-related apps
https://api.realdevsquad.com/
MIT License
46 stars 201 forks source link

Removed checkIsVerifiedDiscord for discord-actions/nicknames/sync API #1969

Closed Pavangbhat closed 3 months ago

Pavangbhat commented 3 months ago

Date: 14-03-2024

Developer Name: Pavan Bhat


Issue Ticket Number

Description

Removed Middleware for Reference:

image

This route discord-actions/nicknames/sync is behind a middleware accessing req.userData which would only be available if the call is made through website-dashboard. As we move these routes to a cronjob, we need to remove this check. Have verified req.userData is not being used for this route's controller and is safe to remove

Documentation Updated?

Under Feature Flag

Database Changes

Breaking Changes

Development Tested?

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

Pavangbhat commented 3 months ago

This issue will solutioned https://github.com/Real-Dev-Squad/website-backend/issues/1973 here