search

Real-Dev-Squad / website-backend

The backend code for all our website-related apps
https://api.realdevsquad.com/
MIT License
50 stars 216 forks source link

remove all `dev=true` feature flag from the main branch that are on prod for more than 14 days #2075

Open yesyash opened 3 weeks ago

yesyash commented 3 weeks ago

Issue Description

iamitprakash commented 3 weeks ago

if needed more info on this please get in touch with @prakashchoudhary07 @iamitprakash @yesyash

samarpan1738 commented 3 weeks ago

Doubts

  1. How to identify that a feature flag has been live on prod for more than 14 days? (My guess is by checking when the PR was merged on the prod branch)
  2. Do we need to keep only the dev == true flows?

@prakashchoudhary07 @iamitprakash @yesyash

samarpan1738 commented 1 week ago

APIs with feature flag

  1. POST /discord-actions/nicknames/sync
  2. GET /logs
  3. POST /extension-requests
  4. GET /extension-requests/self
  5. GET /requests
  6. POST /requests
  7. PUT /requests/:id
  8. GET /users
  9. GET /users/username
  10. GET /users/search
  11. GET /tasks
  12. GET /github/callback

@iamitprakash

samarpan1738 commented 6 days ago

Usages of APIs with feature flag in other repositories

Note: Checked means FF is being used and unchecked means FF is not being used

  1. POST /discord-actions/nicknames/sync
  2. website-dashboard :white_check_mark:
  3. cron-jobs :white_check_mark:
  4. GET /logs
  5. website-dashboard :white_check_mark:
  6. website-api-contracts :white_check_mark:
  7. POST /extension-requests
  8. Reasons for adding dev FF
  9. Create multiple extension requests - PR link
  10. Usages
  11. mobile-app :red_square:
  12. website-my - Partial Use :yellow_square:
  13. website-api-contracts :white_check_mark:
  14. GET /extension-requests/self
  15. website-my :white_check_mark:
  16. website-api-contracts :white_check_mark:
  17. GET /requests
  18. website-api-contracts :white_check_mark:
  19. website-my :white_check_mark:
  20. website-dashboard :white_check_mark:
  21. POST /requests
  22. website-my :white_check_mark:
  23. website-api-contracts :white_check_mark:
  24. PUT /requests/:id
  25. website-dashboard :white_check_mark:
  26. GET /users - Discussed with Prakash. Skipping this for now since it's not being used in majority of the places
  27. Reason for adding dev FF
  28. To get user by discord id through a query param for /user discord command
  29. Change query param with name query to q
  30. Usages
  31. discord-slash-commands - Partial use :yellow_square:
  32. members-site :red_square:
  33. mobile-app :red_square:
  34. website-dashboard :red_square:
  35. website-status :red_square:
  36. GET /users/username - dev FF is still being used here. Skip this
  37. website-my :white_check_mark:
  38. GET /users/search Discussed with Prakash. Skipping this for now since it's not being used in majority of the places
  39. Reason for adding dev FF
  40. Add pagination when multiple filter is applied and user count greater than 100 - PR link
  41. Usages
  42. website-dashboard - Partial use :yellow_square:
  43. discord-slash-commands :red_square:
  44. GET /tasks
  45. discord-slash-commands :white_check_mark:
  46. mobile-app :white_check_mark:
  47. website-dashboard :white_check_mark:
  48. website-status :white_check_mark:
  49. GET /github/callback - Discussed with Prakash. Skipping this since he doesn't remember why this was added
  50. Reason for adding dev FF
  51. dev FF is being checked in the redirect url
  52. If dev=true , do not redirect . PR link
samarpan1738 commented 2 days ago

Subtasks

  1. https://github.com/Real-Dev-Squad/website-backend/issues/2128
  2. https://github.com/Real-Dev-Squad/website-backend/issues/2136
  3. https://github.com/Real-Dev-Squad/website-backend/issues/2137
  4. https://github.com/Real-Dev-Squad/website-backend/issues/2138
  5. https://github.com/Real-Dev-Squad/website-backend/issues/2139
  6. https://github.com/Real-Dev-Squad/website-backend/issues/2140
  7. https://github.com/Real-Dev-Squad/website-backend/issues/2141
  8. https://github.com/Real-Dev-Squad/website-backend/issues/2142
  9. https://github.com/Real-Dev-Squad/website-backend/issues/2143
  10. https://github.com/Real-Dev-Squad/website-backend/issues/2144
  11. https://github.com/Real-Dev-Squad/website-backend/issues/2145
  12. https://github.com/Real-Dev-Squad/website-backend/issues/2146
samarpan1738 commented 8 hours ago

Pull requests

  1. https://github.com/Real-Dev-Squad/website-backend/pull/2150
  2. https://github.com/Real-Dev-Squad/website-backend/pull/2148
  3. https://github.com/Real-Dev-Squad/website-backend/pull/2149
  4. https://github.com/Real-Dev-Squad/website-backend/pull/2151
  5. https://github.com/Real-Dev-Squad/website-backend/pull/2152
  6. https://github.com/Real-Dev-Squad/website-backend/pull/2153
  7. https://github.com/Real-Dev-Squad/website-backend/pull/2154