search

Real-Dev-Squad / website-crypto

RDS bank where you can view and manage your currency
https://crypto.realdevsquad.com/
MIT License
8 stars 64 forks source link

env config done #235

Closed VenomFate-619 closed 2 years ago

VenomFate-619 commented 3 years ago

.env.production early not added in ignore file that why it is as it is. I was not too sure what to add in gitignore as well. I had added .env.example

VenomFate-619 commented 3 years ago

@swarajpure Should I close this PR or any update to de done

swarajpure commented 3 years ago

@swarajpure Should I close this PR or any update to de done

Why close? Do you not want it to be merged? 🤔

VenomFate-619 commented 3 years ago

@swarajpure Should I close this PR or any update to de done

Why close? Do you not want it to be merged? thinking

Yes, I want it to be merged, but it has been opened for a long time So I thought that it won't be merged in future.

swarajpure commented 3 years ago

@swarajpure Should I close this PR or any update to de done

Why close? Do you not want it to be merged? thinking

Yes, I want it to be merged, but it has been opened for a long time So I thought that it won't be merged in future.

It's important that the reviewer is in loop when you make changes, otherwise they won't come to know that required changes are done and hence PR might become stale. Please ensure to tag the reviewers on Discord channel once you've made changes (can't rely on GitHub notifications, there are always tons of them)

MehulKChaudhari commented 2 years ago

Closing this PR, we already have .env.development and .env.production. And I don't think so we need .env.test

But if you guys think we want this PR we can always discuss and open this PR.