Real-Dev-Squad / website-crypto

RDS bank where you can view and manage your currency
https://crypto.realdevsquad.com/
MIT License
8 stars 64 forks source link

Feature Added Sidebar. #274

Open ivinayakg opened 2 years ago

ivinayakg commented 2 years ago

A new react component is created. Sidebar is styled with css modules. Below is how it looks. Web_capture_12-7-2022_113158_localhost image

Here I hided the header links on the screen only which means they are still visible in the code. I did that to get the real look of the component. Navigation is also routed with highlighting the active link.

shubham-y commented 2 years ago

@ivinayakg Please add a screenshot of UI in Mobile mode as well.

ivinayakg commented 2 years ago

I don't think that adding a sidebar to every page is good. We cannot add any animation to it as it will re-render upon changing the pages.

use it only once. If you don't have an idea please reach out.

i had my own doubts about this, cause the navbar was getting rendered on every page, so I thought there is a reason behind this or some format that we are following. but for rendering from one component i have to wrap this in the _app.js file's component right?

ivinayakg commented 2 years ago

@MehulKChaudhari I have noted your requested changes and will revert you with them as soon as possible. @shubham-y I don't have the design template of how it should look on mobile therefore it may look broken, on mobile view

MehulKChaudhari commented 2 years ago

I don't think that adding a sidebar to every page is good. We cannot add any animation to it as it will re-render upon changing the pages. use it only once. If you don't have an idea please reach out.

i had my own doubts about this, cause the navbar was getting rendered on every page, so I thought there is a reason behind this or some format that we are following. but for rendering from one component i have to wrap this in the _app.js file's component right?

Please ask if you have a doubt. And yes you have to wrap it in _app.js file

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
website-crypto ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 10:14AM (UTC)