Stop tests on push - Githubissues

Real-Dev-Squad / website-crypto

RDS bank where you can view and manage your currency

https://crypto.realdevsquad.com/

MIT License

8 stars 64 forks source link

Stop tests on push #283

Open RitikJaiswal75 opened 2 years ago

RitikJaiswal75 commented 2 years ago

Issue

When a PR is created, the git workflow runs tests on all the pull requests, but once the tests are run on pull requests they run again during push

When was the issue discovered?

The issue was discovered on 18th August 2022 during a hangout call while trying to merge PRs.

Files that might be creating this

.github/workflows/test.yml

Screenshot of the Problem

bajajcodes commented 1 year ago

~~Hey @RitikJaiswal75 can you assign this issue to me?~~ Assigned, and PR raised.

MehulKChaudhari commented 1 year ago

Hey, I think it's good that the tests are run after every commit. It gives us an idea of which commits made the tests fail.

bajajcodes commented 1 year ago

Hey, I think it's good that the tests are run after every commit. It gives us an idea of which commits made the tests fail.

This can be done locally as well, if TDD is followed.

MehulKChaudhari commented 1 year ago

Hey, I think it's good that the tests are run after every commit. It gives us an idea of which commits made the tests fail.

This can be done locally as well, if TDD is followed.

Yes, But what if developer didn't fix the tests which are breaking or didn't run tests locally? how will reviewer know whether there are breaking changes or not?