search

Real-Dev-Squad / website-crypto

RDS bank where you can view and manage your currency
https://crypto.realdevsquad.com/
MIT License
8 stars 64 forks source link

upgrade the node, nextjs and react version #309

Closed RitikJaiswal75 closed 1 year ago

RitikJaiswal75 commented 1 year ago

This PR upgrades the versions of the dependencies

Package previous version new version
Node 14 18
next 10 13
react 17 18
react dom 17 18

[!NOTE] In multiple Link tags you will fing a legacy behaviour attribute as on implementing next 13 we can not use anchor tah inside link tags. Since this PR just deals with the version upgrades thus i am not adding any major code changes to it.

[!WARNING] Currently the deployments via vercel are failing, we do expect them to fail as well as in the current scenario we are not making the crypto site public. We do not plan to make it public yet.

Visuals of Site working

https://github.com/Real-Dev-Squad/website-crypto/assets/57758447/dc8ef7bd-b7bb-4e20-a183-d7a3011d39ca

Closes: #310

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-crypto ❌ Failed (Inspect) Oct 14, 2023 8:46pm
RitikJaiswal75 commented 1 year ago

can you please help me the reason to upgrade and why this partical one, ant ticket in place, along with regression test proof like because of version dependency nothing is/are breaking at runtime

I have upgraded from node 14 to node 18 as per discussion with @ankushdharkar to keep the project compatible with upcoming versions.

Same goes for upgrading from next 10 to next 13

Since i upgraded to next 13 it is mandatory to update to react 18

iamitprakash commented 1 year ago

can you please help me the reason to upgrade and why this partical one, ant ticket in place, along with regression test proof like because of version dependency nothing is/are breaking at runtime

I have upgraded from node 14 to node 18 as per discussion with @ankushdharkar to keep the project compatible with upcoming versions.

Same goes for upgrading from next 10 to next 13

Since i upgraded to next 13 it is mandatory to update to react 18

please add this in ticket and FW to me and build is failing as well, TEST proof is needed

RitikJaiswal75 commented 1 year ago

is index.js file change is part of version upgrade ..?

Explained it as a note provided over the main comment

iamitprakash commented 1 year ago

is index.js file change is part of version upgrade ..?

Explained it as a note provided over the main comment

All details should be in separate task/issues ticket

RitikJaiswal75 commented 1 year ago

please add this in ticket and FW to me and build is failing as well, TEST proof is needed

This is the spike ticket where i will be researching and making future updates to the project: https://github.com/Real-Dev-Squad/website-crypto/issues/308

iamitprakash commented 1 year ago

please add this in ticket and FW to me and build is failing as well, TEST proof is needed

This is the spike ticket where i will be researching and making future updates to the project: #308

renamed as [POC] as things are not clear in CI, please keep updating as progress in investigation

RitikJaiswal75 commented 1 year ago

is index.js file change is part of version upgrade ..?

Explained it as a note provided over the main comment

All details should be in separate task/issues ticket

could you please elaborate on this

iamitprakash commented 1 year ago

is index.js file change is part of version upgrade ..?

Explained it as a note provided over the main comment

All details should be in separate task/issues ticket

could you please elaborate on this

plane english

RitikJaiswal75 commented 1 year ago

plane english

I still could not get you