Real-Dev-Squad / website-status

Shows a roadmap of the ongoing projects being done
https://status.realdevsquad.com/
MIT License
21 stars 145 forks source link

feat: add expand feature in progress update card component on click #1111

Closed satyam73 closed 3 months ago

satyam73 commented 3 months ago

Date: 09-02-2024

Developer Name: Satyam Bajpai


Issue Ticket Number

Description

In this PR I have added progress update card to expand and shrink on click. When in expand mode a user can see every content of the progress update i.e

Tests PR for this PR is here at,

Note: Tests are to handled separately, please review this one and I will reference test in this one and then only merge both feature and tests PR.

Documentation Updated?

Under Feature Flag

Database Changes

Breaking Changes

Development Tested?

Screenshots

image

Desktop View

image

Tab View

image

Mobile view

Test Coverage

Screenshot 1

Additional Notes

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:54am
ajoykumardas12 commented 3 months ago

Some checkboxes are not filled. About the design, I don't think long content should be trimmed as 'read more' after user already presses accordion to see the updates.

sahsisunny commented 3 months ago

Still have a scrollbar I don't think it should be there image

sahsisunny commented 3 months ago

The first progress update is not collapsable it is expected?

sahsisunny commented 3 months ago

when we click anywhere on the expanded progress update it collapses it is the right behavior?

sahsisunny commented 3 months ago

image

it's hard to differentiate which progress update is expanded and which is collapsed. Ca we make the darker or another light color background to any one state?

satyam73 commented 3 months ago

The first progress update is not collapsable it is expected?

Yes it is intended as per the requirement

satyam73 commented 3 months ago

If i click on days ago to check tooltip in mobile, it will expand the card as well. Is this intentional?

Fixed

satyam73 commented 3 months ago

Still have a scrollbar I don't think it should be there image

Fixed

satyam73 commented 3 months ago

on days ago to check tooltip in mobile, it will expand the card a

Please refer description for info about tests

satyam73 commented 3 months ago

If a single word is too long. It is breaking. Rest looks good to me. overflow

Fixed thanks for pointing out!