Real-Dev-Squad / website-status

Shows a roadmap of the ongoing projects being done
https://status.realdevsquad.com/
MIT License
21 stars 145 forks source link

Added the nav bar similar to home page #199

Closed rohan09-raj closed 2 years ago

rohan09-raj commented 2 years ago

Closes #145 Before : Screenshot (4) After : (Mobile View) Screenshot (19) (Tablet View) Screenshot (18) (Desktop/Laptop View) Screenshot (17)

rahilkapoor commented 2 years ago

Looks perfect to me! But there is a slight change in the navbar...We have removed the home tab thus we will be navigating to the home page via the logo itself navbar

Ignore the right corner sign-in thing for now!

rohan09-raj commented 2 years ago

Ohh okay, I forgot to remove it, will do it ASAP. And Is the padding fine or should I increase it to match the design.

rahilkapoor commented 2 years ago

You might have to increase the padding for it to look something similar...(make changes which you feel are necessary to make it look alike)βœ”

rohan09-raj commented 2 years ago

@whyDontI I have tested on multiple screen sizes and none of them is causing is issue. Can you please share the dimensions in which the horizontal scroll is caused or some reference please.

whyDontI commented 2 years ago

Not a problem with resolution, the problem is with the tasks page I guess, it's not replicating on any other pages. Can you check?

rohan09-raj commented 2 years ago

Not a problem with resolution, the problem is with the tasks page I guess, it's not replicating on any other pages. Can you check? @whyDontI Unable to get you. πŸ˜…πŸ˜…, tasks page is working fine with other pages too. (mine, DS, Open PRs etc.). I checked all the pages. Yeah, there are some visual differences like font size and color of this (something went wrong! Please contact admin) text across all these pages. So, do I need to fix those or are you only talking about navBar ?? I couldn't get any issue regarding horizontal scrollπŸ˜…πŸ˜…

rohan09-raj commented 2 years ago

Not a problem with resolution, the problem is with the tasks page I guess, it's not replicating on any other pages. Can you check?

Made the suggested change.

rohan09-raj commented 2 years ago

Good work πŸ₯³

Thank you πŸ˜ƒ