Fetch images from cloudinary instead of github

Real-Dev-Squad / website-status

Shows a roadmap of the ongoing projects being done

https://status.realdevsquad.com/

MIT License

21 stars 145 forks source link

Fetch images from cloudinary instead of github #310

Closed heyrandhir closed 1 year ago

heyrandhir commented 1 year ago

What is the change?

Closes #311

[x] Fetch images from Cloudinary instead of GitHub

Is it bug?

Steps to repro
Expected
Actual

*Dev Tested?

[x] Yes
[ ] No

*Tested on:

Platforms

[x] Web

Browsers

[x] Chrome
[ ] Safari
[ ] Firefox

Before / After Change Screenshots

For visual or interaction changes. Can be video / screenshot.

rajat-mehra05 commented 1 year ago

Hey @heyrandhir Can you also provide which issue no. does this PR closes ? Thanks.

heyrandhir commented 1 year ago

Hi, @rajat-mehra05 Thanks for the Review. Made the changes. and added the issue ticket. 🙂

Maheima commented 1 year ago

@heyrandhir a suggestion: For things like Steps to repro Expected Actual before/after screenshots time and many points in the PR's description that you have not answered could be removed. These are just pointers to help you write a good description.

heyrandhir commented 1 year ago

Converted this to draft as our free usage of Cloudinary has exceded.

vercel[bot] commented 1 year ago

@heyrandhir is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

heyrandhir commented 1 year ago

Since this is handled in another PR by Sunny hence closing it