search

Real-Dev-Squad / website-status

Shows a roadmap of the ongoing projects being done
https://status.realdevsquad.com/
MIT License
21 stars 145 forks source link

added shallow routing #324

Closed SimplySonu closed 1 year ago

SimplySonu commented 1 year ago

Closes #324 The page reloads each time a user clicked on the edit button on the status card. To prevent this I have used shallow routing. The URL will get updated to '?edit=true' and the page won't get replaced, only the state of the route is changed.

YashJain24-chief commented 1 year ago

Please add which issue it closes

SimplySonu commented 1 year ago

added, please check @YashJain24-chief

YashJain24-chief commented 1 year ago

So basically when we do shallow routing within the same page, the page won't reload even though the URL is changing and the scroll position won't reset. Is what I'm thinking correct? @SimplySonu

SimplySonu commented 1 year ago

yes your right @YashJain24-chief

YashJain24-chief commented 1 year ago

Looks good to me!

RitikJaiswal75 commented 1 year ago

Please add a video describing the problem and then the video of solved page

SimplySonu commented 1 year ago

@RitikJaiswal75

https://user-images.githubusercontent.com/75324160/198278494-8e308b27-06e8-42ef-aa56-1fdfecf29b5f.mp4

SimplySonu commented 1 year ago

@YashJain24-chief @RitikJaiswal75 @ivinayakg Please review.

vercel[bot] commented 1 year ago

@SimplySonu is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

Maheima commented 1 year ago

Please write test cases

SimplySonu commented 1 year ago

Please write test cases @Maheima Actually I think we cannot add a test case for this. Only a query parms is been added in the url. Please give me your thoughts on this if I am wrong.