Closed anishpawaskar closed 11 months ago
@anishpawaskar is attempting to deploy a commit to the RDS-Team Team on Vercel.
A member of the Team first needs to authorize it.
Please be descriptive about the PR. Reviewers should get the context on why the failing tests are not fixed and and why they need to be skipped.
Please be descriptive about the PR. Reviewers should get the context on why the failing tests are not fixed and and why they need to be skipped.
Okay ill do that
Please resolve the conflicts. I'll approve post that since my approval will become stale anyway after you push merge commits.
I’ll resolve it once i know about testing.
LGTM, please make sure that the we take care of the failing test in another PR as discussed
Yes
Here's the issue ticket which was assigned to me: [(https://github.com/Real-Dev-Squad/website-status/issues/530)]
Changes Made
Added Loader component in
src/components/Layout/index.tsx
and it will only shows up when the isLoading is true and we are skipping test of navbar which are failing. The test which are skipped fromNavbar.test.tsx
aretest('check for leading state')
andtest('user whether loggedIn or not')
.As i don’t know what is RTL testing so that’s why i skipped tests.
Fix test for navbar Here's the issue ticket to fix test for navbar [(https://github.com/Real-Dev-Squad/website-status/issues/549)]
Before:
https://user-images.githubusercontent.com/22213872/237061764-adb37943-c5bd-4f88-ae6b-fc2df9a5c6f0.mp4
After:
https://user-images.githubusercontent.com/22213872/237062122-1b417852-9d87-46cb-92b8-766482f115cd.mp4