Real-Dev-Squad / website-status

Shows a roadmap of the ongoing projects being done
https://status.realdevsquad.com/
MIT License
21 stars 145 forks source link

fix: navbar not showing login when user Logged Out #589

Closed WYGIN closed 6 months ago

WYGIN commented 11 months ago

Issue: #583

Description:

When the user is not logged in the website is showing similar screen with profile, similar to when the user is loggedin

Anthing you would like to inform the reviewer about:

Dev Tested:

Images/video of the change:

Before:

Screenshot_20230526-160112.png

After:

Screenshot_20230526-163742

Follow-up Issues (if any)

vercel[bot] commented 11 months ago

@WYGIN is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

WYGIN commented 11 months ago

Ok i will

WYGIN commented 11 months ago

Hi Sai Kiran, You provided in description that you are fixing image

But Now you start changing other files also...Is all these file solving problem of issue that you written in description??

If not please work on particular issue which have to solve and for other fixing make a Seperate issue ticket

No, all those file changes are related to fixing the test issue & form should have a default role of form but in my case it is making my tests fail again so i made some changes to other files too. Take a look at this url: https://html.spec.whatwg.org/multipage/forms.html#the-form-element

All these file changes are for passing unit tests

WYGIN commented 10 months ago

@sahsisunny is the signin button working perfectly you mean or not? & thanks for the review

sahsisunny commented 10 months ago

@sahsisunny is the signin button working perfectly you mean or not? & thanks for the review

It's working @WYGIN

WYGIN commented 10 months ago

Please attach test coverage to it

@RitikJaiswal75 added test coverage please check it

prakashchoudhary07 commented 9 months ago

Tests are failing, please look into it