search

Real-Dev-Squad / website-status

Shows a roadmap of the ongoing projects being done
https://status.realdevsquad.com/
MIT License
21 stars 145 forks source link

[Feature] : User should be able to update progress through progress bar slider #646

Closed Pratiyushkumar closed 10 months ago

Pratiyushkumar commented 11 months ago

Close: #626

Description:

Previously, the user needed to go to my site and update his task progress.

Fix -

Now user can go to his task and click on the update progress button and after that, through the slider, he can update his progress and click on the save progress button to save the progress of the task and only the assignee can do it.

Dev Tested:

Images/video of the change:

Before change -

image

After change -

https://github.com/Real-Dev-Squad/website-status/assets/82165483/f8f13cc7-d099-472b-9c8b-f6aa315df9f8

since, sometimes it takes time for the percent completed to get updated, so on refreshing we can see below the output

Test Issue -

683

Test PR -

686

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 7:43pm
shubhamsinghbundela commented 11 months ago

Hi @Pratiyushkumar bhai After seeing video...I have some question...please reply :)

  1. when we update on my-site our progress...its reflect just after changing the progress bar...So why here its takes time??
  2. What is percentage criteria of color change on progress bar?? i.e. red, green yellow
Pratiyushkumar commented 11 months ago

Please add the test with coverage

@sahsisunny Test will be written in later issue

sahsisunny commented 11 months ago

Please add the test with coverage

@sahsisunny Test will be written in later issue

Please create the issue ticket and mention to in this PR

Pratiyushkumar commented 10 months ago

Please add the test with coverage

@sahsisunny Test will be written in later issue

Please create the issue ticket and mention to in this PR

https://github.com/Real-Dev-Squad/website-status/issues/657

Pratiyushkumar commented 10 months ago

Can you please work on this progress bar color change after the progress bar updation to green 75-100%, 50-75% yellow, 0-50 red

https://github.com/Real-Dev-Squad/website-members/issues/161 It's working according to the requirement in the above issue mentioned so no need to work on this

shubhamsinghbundela commented 10 months ago

Can you please work on this progress bar color change after the progress bar updation to green 75-100%, 50-75% yellow, 0-50 red

Real-Dev-Squad/website-members#161 It's working according to the requirement in the above issue mentioned so no need to work on this

Hi @Pratiyushkumar I didn't understand

Pratiyushkumar commented 10 months ago

Can you please work on this progress bar color change after the progress bar updation to green 75-100%, 50-75% yellow, 0-50 red

Real-Dev-Squad/website-members#161 It's working according to the requirement in the above issue mentioned so no need to work on this

Hi @Pratiyushkumar I didn't understand

So basically progress bar color change is working as per the design guidelines given by Ankush in this issue
https://github.com/Real-Dev-Squad/website-members/issues/161 so we don't need to worry about the color change, I have debugged the code according and didn't find any bug

sahsisunny commented 10 months ago

Where is the test coverage @Pratiyushkumar ?

Pratiyushkumar commented 10 months ago

created a ticket to refactor the code for the card component - https://github.com/Real-Dev-Squad/website-status/issues/687

Pratiyushkumar commented 10 months ago

NIT:

You are using fragments here, here and here even if it's not required.

Note: You can choose to ignore this comment as it is just pointing out a small thing to keep in mind in the future.

fixed