Closed vinit717 closed 9 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
status-app | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 11, 2023 10:50am |
Reason for not able to test setSearchTerm Testing an internal state variable very much goes against the philosophy behind react-testing-library. That lib is focused on the user, and what the user can see. The user has no concept of a state variable. Instead of testing that, think of the changes the user would see, and test for that. How is the UI updated? What different markup or styling is displayed? Consider how to test from the user's perspective https://testing-library.com/docs/guiding-principles/ https://testing-library.com/docs/queries/about/#priority
After clicking save the name/description does not get updated immediately, the transition from previous to updated name/description is not smooth and also the dependencies shows - no dependencies before the loading... is rendered
no dependencies before the loading... is rendered
After clicking save the name/description does not get updated immediately, the transition from previous to updated name/description is not smooth and also the dependencies shows - no dependencies before the loading... is rendered
As for saving for name/description, it is an API issue which is a patch request taking some time to update the request and for no dependencies, it is because it first takes the id of the task then it makes a call no it neither fetching nor loading state is their
For API performance, I have created the issue below
for unnecessary API call, I have created the issue below
@vinit717 APIs will always take time, even if you optimize. There are two ways to handle this.
And regarding dependencies what I meant is that when you do add some dependency and try to save - before it shows loading it shows 'no dependencies' briefly. If this is getting fixed by the above mentioned bugs then fine.
Issue:
Description:
Implement a task title search functionality to add the task in the dependsOn field
Anything you would like to inform the reviewer about:
Dev Tested:
Images/video of the change:
https://github.com/Real-Dev-Squad/website-status/assets/111434418/c7f3497b-596a-4146-9cf3-9e22e5670227
Follow-up Issues (if any)