Fix the editable mode of task-card for superuser

AnjaliDeshwani commented 9 months ago

Issue:

Editable mode of task-card for superuser -

Task title can not be edited, on clicking title it redirects super user to task details page.
There is no icon button to come out of editable mode.
On selecting user as a assignee, user's profile picture doesn't reflect correctly corresponding to the assigned user.
There is no spinner/checkmark to indicate the user that data is saving/saved.

Description:

Changes are made to fix all the above issues. For superuser in editable mode, text area for title is shown. User can still navigate to the task details page on click of title by coming out of editable mode.
Separate(X) icon is shown, on click of which user can come out of editable mode.
In Assigned to field, on selecting user from the suggestion list, profile picture also gets reflected correctly.
In all the editable field spinner is shown when data is being saved, and, once successfully saved checkmark is shown. In case of error, toast is shown.

Dev Tested:

[x] Yes

Images/video of the change:

Before Change -

https://github.com/Real-Dev-Squad/website-status/assets/30263070/189ae06b-d27a-433f-b22e-6ba6049d6168

After Change -

https://github.com/Real-Dev-Squad/website-status/assets/30263070/6f7b49bf-c15b-4fcc-9069-32f27192a3c2

When there is error while saving data -

https://github.com/Real-Dev-Squad/website-status/assets/30263070/acb4e06b-8aaf-403b-9c37-ec2a489d585d

Test Coverage Before

TestCoverage_Before

Test Coverage After

TestCoverage_After

vercel[bot] commented 9 months ago

@AnjaliDeshwani is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

AnjaliDeshwani commented 9 months ago

in Edit mode Text font looks different, can you align that

It's fixed now.

vinit717 commented 9 months ago

Why not toast for success also? why we are creating different logic for updates as we have a loader, and success toast already

AnjaliDeshwani commented 9 months ago

Why not toast for success also? why we are creating different logic for updates as we have a loader, and success toast already

@vinit717 - It was the requirement told to me by Ankush, as per that we need to show spinner besides editable field when it's being getting saved, and once saved we need to show the checkmark(for few seconds) to indicate that data is being saved.

For error, I am showing toast. If you have any good suggestion to show or make it differently, we can discuss that. Let me know if we need to discuss this.

AnjaliDeshwani commented 9 months ago

is this behind feature flag

No, It is not behind feature flag. Will be visible to all users in editmode.

iamitprakash commented 9 months ago

is this behind feature flag

No, It is not behind feature flag. Will be visible to all users in editmode.

please put this under feature flag

sahsisunny commented 9 months ago

Can you add the test coverage stats?

AnjaliDeshwani commented 8 months ago

Can you add the test coverage stats?

@sahsisunny - I have added few test cases and updated the coverage please check. Thank you.

AnjaliDeshwani commented 8 months ago

Closing this PR as because of rebase and reverting changes again it's facing some conflicting issues while someone approves the PR.

Opened the new PR - https://github.com/Real-Dev-Squad/website-status/pull/839

Real-Dev-Squad / website-status