feat: update query param on issues tab url based on search query

[j24m]

Developer name : @j24m

Backend Changes :

• [ ] Yes
• [x] No

  Frontend changes :

  • [x] Yes
  • [ ] No

    Is Under Feature Flag :

  • [x] Yes
  • [ ] No

    Database changes :

  • [ ] Yes
  • [x] No

    Breaking changes :

  • [ ] Yes
  • [x] No

    Tested on local :

  • [x] Yes
  • [ ] No

    Issue :

  • https://github.com/Real-Dev-Squad/website-status/issues/971

    Description :

  • This pull request introduces the efficient representation of search query by updating it as query param on the issues tab address bar.

    Code Changes :

  • utils/getQueryString.test.tsx : Efficiently handles the processing of search query in both the cases where there is a query string and where there is no query string i.e no value passed.
  • issues/index.tsx : If 'dev' is set to 'true', we update the URL by appending the 'q' parameter with a search prefix for a more meaningful URL structure. Additionally, we split and extract relevant search information from the URL query, so as to fetch issues correctly.
  • tests/Utils/getQueryString.test.ts : Provided test cases cover both empty and non-empty search queries, ensuring that the getQueryString function behaves as expected in all scenarios.

    Anything you would like to inform the reviewer about:

Dev Tested :

• [x] Yes

  Test Stats :

  

Images/video of the change :

https://github.com/Real-Dev-Squad/website-status/assets/53934353/4f88280b-4a3a-4d90-b767-fce913c1aa15

Follow-up Issues (if any) :

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
status-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 10, 2023 10:13am

[j24m]

• The query should persist in the search bar after sharing.
• The API should be search?q=dark%20mode or search?q=dark+mode (That's what Google use)

• Thankyou for pointing this out, I will persist the search query in search bar.
• Coming to your second point I have constructed the query param as per discussion with @ankushdharkar, here is the screenshot for the same : -So for issues it should be /issues?q=<some-key>%3A<dynamic-string>
• Example : q=search%3Adark+mode

[Ajeyakrishna-k]

Please add tests for your feature.

[gauravsinhaweb]

• The query should persist in the search bar after sharing.
• The API should be search?q=dark%20mode or search?q=dark+mode (That's what Google use)

• Thankyou for pointing this out, I will persist the search query in search bar.
• Coming to your second point I have constructed the query param as per discussion with @ankushdharkar, here is the screenshot for the same : -So for issues it should be /issues?q=<some-key>%3A<dynamic-string>
• Example : q=search%3Adark+mode

For this case, it looks good.

[j24m]

You haven't added a test case to verify whether the changes are actually reflected in the search URL or not when the input field is changed.

Done.

[j24m]

The search should show closest suggestion of query EX - If user search Dark mod missing e, the result should show for dark mode currently it is showing the exact value to query

Hello, regarding this comment of yours Gaurav : https://github.com/Real-Dev-Squad/website-status/pull/989#pullrequestreview-1724069975 The issue we are addressing in this task is only to update query params, the comment that you have put is out of scope for this issue. Here is the issue link, acceptance criteria has been mentioned very clearly : https://github.com/Real-Dev-Squad/website-status/issues/971

[gauravsinhaweb]

The search should show closest suggestion of query EX - If user search Dark mod missing e, the result should show for dark mode currently it is showing the exact value to query

Hello, regarding this comment of yours Gaurav : https://github.com/Real-Dev-Squad/website-status/pull/989#pullrequestreview-1724069975 The issue we are addressing in this task is only to update query params, the comment that you have put is out of scope for this issue. Here is the issue link, acceptance criteria has been mentioned very clearly : https://github.com/Real-Dev-Squad/website-status/issues/971

If the behaviour is same, after making your changes then it's fine.