search

Real-Gecko / Filemin

File manager for Webmin written completely in perl
Other
64 stars 16 forks source link

List of proposed improvements and some bugs to fix #33

Closed iliajie closed 8 years ago

iliajie commented 9 years ago

At first, I would like to say that Filming is totally amazing! Thank you for your efforts!

I would like to propose few things:

Major:

  1. Adding to file-type SELinux labels (you can see them when you add Z to the keys, like ls -lsaZ) - must have!
  2. Manually entering the path by clicking Ctrl+L and/or other means
  3. Remove action column and replace with Bootstrap Context menu (http://sydcanem.com/bootstrap-contextmenu/). I just did this for my Karateka project, combined with data-tables and it's awesome! Tricky but awesome!
  4. No screen reloads! Start making things AJAX like style. Just reload table body (<tbody>), not the whole thing. - It's not needed and makes things annoying. Especially same should be done when copy/paste/add bookmark and stuff. It's very easy to do really. Block the screen everytime the request is made to the server, showing small loader at the bottom of the screen, when done popup a message, that files are copied/pasted or something. Recommend: http://malsup.com/jquery/block/, http://github.hubspot.com/messenger/
  5. Let user choose the destination path, when user does operations on files, folders. Like if you want to extract an archive it doesn't let you choose the path. You could use default Webmin file_chooser or enter it manually.
  6. Don't cookies, use localStorage - it much more awesome! DataTables use it. See it console. Read more: http://www.w3schools.com/html/html5_webstorage.asp

Minor (fast and easy to do):

  1. Auto-focus on page load to table search field.
  2. Adding more space between label-icons and text like one extra &nbsp; Same buttons on top - the icon should get extra &nbsp; on the left and the right.
  3. Fix a bug when clicking on select all/inverse in Authentic Theme, if custom checkboxes used, they must be update by running $('.acheckbox, .aradio').icheck('updated'); Before running it you can check if user hasn't disabled it as it's enabled by default by testing global var settings_window_customized_checkboxes_and_radios
  4. Fix sorting files by size - it's done and woeking in Authentic Theme
  5. When user changes Module name in Webmin->Configuration, using Module Titles. It changes in left menu but when you actually get to Filemin, default name (Filemin) is displayed. Should be fixed.
iliajie commented 9 years ago

Also adding search in files, like:

/usr/bin/grep -Ril "real-gecko" "/";

All of this should be returned from server side using ajax requests. It's really not the hard.