Real-Serious-Games / C-Sharp-Promise

Promises library for C# for management of asynchronous operations.
MIT License
1.2k stars 149 forks source link

tc39 spec conformance #62

Closed theJenix closed 6 years ago

theJenix commented 6 years ago

Changed Finally implementation to conform to spec tc39: When calling Finally that accepts an Action, resolved values are passed through the promise chain When calling Finally that accepts an Action, rejected promise exceptions are passed through the promise chain When an exception is thrown in Finally, the resulting promise rejects with the new exception (even if the previous promise was rejected)

Added tests to test this behavior and other behavior of tc39, e.g. throwing exceptions in finally

Scope Creep: Fixed a compiler error in exception_in_reject_callback_is_caught_by_chained_catch Fixed a handful of tests that had asserts in the promise callbacks after the counter that was used to verify success/failure