search

Real-Serious-Games / C-Sharp-Promise

Promises library for C# for management of asynchronous operations.
MIT License
1.2k stars 149 forks source link

Promise<T>.All should not use value returning catch #67

Closed sindrijo closed 6 years ago

sindrijo commented 6 years ago

Now that we have IPromise Catch(Action on IPromise the static All method should us the non-value version of Catch to avoid the ugly return default(PromisedT)

RoryDungan commented 6 years ago

Good point. I think this would work by just deleting that return default(PromisedT); line. Can't see how that would break any existing code, so unless there's anything else you think would be worth changing I'll switch it over. 👍

sindrijo commented 6 years ago

Yes, I can't see how it would break anything either.

RoryDungan commented 6 years ago

I've fixed this now.