search

Real-Serious-Games / C-Sharp-Promise

Promises library for C# for management of asynchronous operations.
MIT License
1.19k stars 149 forks source link

NuGet package contains non-optimized (Debug) assembly #84

Open abogarsukov opened 6 years ago

abogarsukov commented 6 years ago

For some reason NuGet package for the project contains non-optimized (Debug) assembly RSG.Promise.dll Is this intended? If not, please upload a new version with the release assembly.

Arvtesh commented 5 years ago

Any updates on this one? It seems logical to have release assemblies in NuGet package.

RoryDungan commented 5 years ago

Yeah this should probably be changed to the release one. There wasn't any particular reason I set it up that way apart from that it was the default config and I do sometimes find it useful being able to just copy the PDB files into a project and debug C-Sharp-Promise from there. Obviously that's a bit of a niche use-case because it only applies to people working on C-Sharp-Promise and for most people having a smaller DLL is better.

I don't work at RSG any more but if someone wanted to make a PR that changes the Nuget config to use release assemblies I don't see any reason why we couldn't merge it and push a new minor version out to Nuget.