search

Real-Serious-Games / C-Sharp-Promise

Promises library for C# for management of asynchronous operations.
MIT License
1.2k stars 149 forks source link

Promise base from nloewen [WIP] #87

Open ericnewton76 opened 6 years ago

ericnewton76 commented 6 years ago

Picking up where nloewen left off.

Merged all master changes into promise_base

Tests all come back fine.

ericnewton76 commented 6 years ago

of note, should formally remove packages folder from repo and .nuget folder

ericnewton76 commented 5 years ago

Hello? Anybody here to merge this in? Or at least review?

RoryDungan commented 5 years ago

Hey, sorry it's taken me a while to get back to you. I've been out of office the past week and have also had quite a few other projects going on. Overall I think it looks like a great addition and it looks like all the tests pass.

The only thing I think I'd consider changing is renaming Promise_Base to PromiseBase because elsewhere we try to stick to PascalCase for class names. Promise_NonGeneric breaks this rule but that's because the underscore takes the place of a comma, so it should read as "promise, non-generic". I think in this case "promise base" makes more sense than "promise, base".