Open ericnewton76 opened 6 years ago
of note, should formally remove packages folder from repo and .nuget folder
Hello? Anybody here to merge this in? Or at least review?
Hey, sorry it's taken me a while to get back to you. I've been out of office the past week and have also had quite a few other projects going on. Overall I think it looks like a great addition and it looks like all the tests pass.
The only thing I think I'd consider changing is renaming Promise_Base to PromiseBase because elsewhere we try to stick to PascalCase for class names. Promise_NonGeneric breaks this rule but that's because the underscore takes the place of a comma, so it should read as "promise, non-generic". I think in this case "promise base" makes more sense than "promise, base".
Picking up where nloewen left off.
Merged all master changes into promise_base
Tests all come back fine.