search

Real-Serious-Games / C-Sharp-Promise

Promises library for C# for management of asynchronous operations.
MIT License
1.19k stars 149 forks source link

Updated build script to create Release assemblies as output #95

Open Arvtesh opened 5 years ago

Arvtesh commented 5 years ago

This should fix https://github.com/Real-Serious-Games/C-Sharp-Promise/issues/84.

The build script is updated to create release assemblies as CI output. If I'm correct this should result in release assemblies pushed to NuGet package. Hopefully this will fix the issue linked above.

jdnichollsc commented 5 years ago

Hi @RoryDungan, what do you think about this change? 👍

RoryDungan commented 5 years ago

Yeah I think it looks good but I don't work at RSG any more. @kalvinpearce or @Borningstar can you merge?

RoryDungan commented 5 years ago

Actually on second thought this might not be best. It won't actually fix #84 because Nuget packages never came from Travis, they're built manually.

Changing the Travis config won't necessarily affect that but we may want to keep using the debug version for running unit tests on Travis for better stack traces in the case a test fails. On the other hand maybe it's best to test the assembly that most closely resembles what should be on Nuget so maybe release is better. I don't think it makes a huge difference in this case.